Many perceived "gun rights" will eventually depend on three words found in the 2nd Amendment, "well regulated militia". A modernized interpretation of those words will change everything. A decision will be made that the old and current interpretation of "everyone" automatically belonging to the militia will be changed and who can belong to the militia and in what capacity will become "well regulated".
As of the 1917 National Guard Act, that part of the 2nd Amendment became worthless.
A law like the 1917 act does not make a Constitutional Amendment worthless. The SCOTUS can at any time hear a challenge to a law thought to be infringing on the Constitution.
The 1917 act changed the status of the state militia's and changed them into quasi federalized troops or no longer legitimate militia's.
If we consider the National Guard to be the militia, why do people who are not in the National Guard have the rights of the 2nd Amendment to have guns? If they are not in the National Guard they are not being regulated.
There are valid and logical arguments about defining the original intent of what the founders considered a "militia".
The States still have the right to a states militia. But there are rules that apply to who can and cannot be called up for federal duty. Let's say there was going to be a dustup between the Feds and a given state. The Feds call up all the people that can be called up. These are the ones that can be called up without a draft.
1. National Guard Members
2. Seperated Members still within their 4 year obligation of Federal Reserve Status
3. Federal Reserves
4. Military Retired Members within their 10 year reserve status commitment.
All others are eligible to be members of the State Militia. But the State Militia does not get any financial support or training support from the Feds like the National Guard does. What has happened, most states no longer feel the need for a States Militia since they can get most of the same support from the National Guard on the Federals Dime for Emergencies. If there was a dustup, a true state Militia would last about an afternoon against a federal military since they would lack the training and equipment to resist very long. The 2nd amendment really went by the way when the weapons of war outgrew us all.